Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit Delivery Services returned for GET /servers/{id}/deliveryservices to ones in the same CDN #7888

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Limit Delivery Services returned for GET /servers/{id}/deliveryservices to ones in the same CDN #7888

merged 1 commit into from
Dec 20, 2023

Conversation

zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Dec 19, 2023 •
edited
Loading

This PR fixes #7887 by making GET /servers/{id}/deliveryservices exclude topology-based DSes that contain the server's cachegroup but are in a different CDN.

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run tests

If this is a bugfix, which Traffic Control versions contained the bug?

8.0.0 RC4

PR submission checklist

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version labels Dec 19, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (36e3ae1) 28.87% compared to head (cddff21) 31.83%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ffic_ops_golang/deliveryservice/servers/servers.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7888      +/-   ##
============================================
+ Coverage     28.87%   31.83%   +2.95%     
  Complexity       98       98              
============================================
  Files           602      719     +117     
  Lines         77355    82731    +5376     
  Branches         90      970     +880     
============================================
+ Hits          22339    26339    +4000     
- Misses        52925    54234    +1309     
- Partials       2091     2158      +67
Flag Coverage Δ
golib_unit 53.85% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.88% <ø> (+0.11%) ⬆️
traffic_monitor_unit 25.47% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.67% <0.00%> (-0.01%) ⬇️
traffic_portal_v2 74.37% <ø> (?)
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 29.15% <0.00%> (+3.46%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kdamichie
kdamichie approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@kdamichie kdamichie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@zrhoffman zrhoffman merged commit 26ef01b into apache:master Dec 20, 2023
43 checks passed
rimashah25 pushed a commit that referenced this pull request Jan 3, 2024
@zrhoffman @rimashah25
Limit Delivery Services returned for GET /servers/{id}/deliveryservic…
40352c1 
…es to ones in the same CDN (#7888)

(cherry picked from commit 26ef01b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdamichie kdamichie kdamichie approved these changes

Assignees
No one assigned
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /servers/{id}/deliveryservices includes topology-based DSes in other CDNs
2 participants
@zrhoffman @kdamichie